fix(grit): patch more parser incompatibilities for complex patterns #5037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
morgante
changed the title
CodSpeed Performance ReportMerging #5037 will not alter performanceComparing Summary
|
ematipico
reviewed
Feb 5, 2025
| } | ||
| } | ||
|
|
||
| private pattern handle_one_statement($class_name, $statements, $states_statements, $static_statements, $render_statements, $constructor_statements, $handler_callback_suffix, $use_ref_from, $use_previous_value_hook) { |
There was a problem hiding this comment.
I suppose here we should break the group on multiple lines. I'll look at it.
It's good to have a complex and long example, we were missing them. Thank you :)
ematipico
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure Biome can parse the full GritQL standard library:
functionneeds to be usable as a name in JavaScriptbubble { ... }is valid GritQLTest Plan
Added spec tests