challenge(formatter): Handle more unary and update expressions as simple arguments #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Formatter
Conaclos
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes:
This effectively matches the PR that fixed the relevant issue for the test in Prettier: prettier/prettier#13115.
+and~are now considered "simple" unary operators as well, and increment and decrement operators are also considered simple. The latter differs slightly from prettier in the operand must only be an identifier and not any other kind of assignment target, but the prettier tests don't test that. This structure will allow Biome to decide how to format those kinds of operands independently in the future.Test Plan
Prettier snapshot now matches and the diff has been removed.