Faster continuous k-mer decomposition #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a faster method for
create_kmers()
that uses the k-mer from the previous position to compute the next position. This way lopping over k is not necessary anymore as opposed to the current method.The performance increase is clear (orange: naive, green: new method):
The following script was used to create the benchmarks:
For easier implementation the k-mer ordering in the alphabet is reversed.