CCD build on install #542
Closed
CCD build on install #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach leads to problems in cross-compilation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an alternative solution to #530. Instead of periodically updating the CCD dataset in version control (Git LFS) as implemented by #541, this PR removes the CCD dataset from version control again and instead creates it directly on installation.
Using Git LFS has multiple disadvanatges: First, Biotite would be locked-in into third-party version control features and, secondly, GitHub provides only a limited download quota from LFS which fills very fast due to CI jobs.
Furthermore, CCD creation on installation automatically ensures that the CCD version is always up-to-date.