Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to RDKit #736

Open
wants to merge 4 commits into
base: interfaces
Choose a base branch
from
Open

Conversation

padix-key
Copy link
Member

@padix-key padix-key commented Jan 14, 2025

As described in #709, this PR adds an interface to RDKit and also sets the design of other future biotite.interface subpackages. Let me know what you think, especially the design on the higher level (e.g. the @requires_version() decorator, adding packaging as dependency, the nomenclature with from_* and to_*)

@t0mdavid-m @JHKru @MaxGreil

Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #736 will not alter performance

Comparing padix-key:rdkit (b84a7db) with main (886b446)

Summary

✅ 59 untouched benchmarks

@padix-key padix-key force-pushed the rdkit branch 2 times, most recently from c6c804e to 0ff9c1e Compare January 18, 2025 16:08
@padix-key padix-key changed the base branch from main to interfaces January 18, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant