-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cowbird README file disappears now that cowbird is a default component #412
Conversation
E2E Test ResultsDACCS-iac Pipeline ResultsBuild URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/2365/Result : success BIRDHOUSE_DEPLOY_BRANCH : cowbird-readme-enable-fix DACCS_CONFIGS_BRANCH : master PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master PAVICS_SDI_BRANCH : master DESTROY_INFRA_ON_EXIT : true PAVICS_HOST : https://host-140-20.rdext.crim.ca PAVICS-e2e-workflow-tests Pipeline ResultsTests URL : http://daccs-jenkins.crim.ca:80/job/PAVICS-e2e-workflow-tests/job/master/1481/NOTEBOOK TEST RESULTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Ouranos overrides JUPYTER_README
.
It is possible that we might need to do something like
export JUPYTERHUB_COWBIRD_README="${JUPYTER_README:-$COMPOSE_DIR/components/cowbird/user_workspace_readme.ipynb}"
@tlvu Need to validate this on your end.
That's fine, as long as they're overriding it in the env.local file, the updated value will be used |
Exact, we use |
Overview
The settings to enable the Cowbird README file (added in version 1.41.0) assumed that the cowbird component would be loaded after the juptyerhub component. Now that the cowbird component is part of the
DEFAULT_CONF_DIRS
and therefore will always be loaded first, this updates the settings so that the README file will be enabled given the new component load order.Changes
Non-breaking changes
Breaking changes
Related Issue / Discussion
Additional Information
birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false