Http status codes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failed because PR is missing #83. |
|
@fmigneault merged. Thanks :) |
|
@cehbrecht do you mind if I tag it as 0.5.2? |
|
@fmigneault sure, go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When raising any
OWSException, the returned response actually always indicate200which is confusing in case of unauthorized or bad requests cases.This PR fixes this by making forbidden services have
401(unauthorized), missing parameters have400(bad request), missing service404(not found), ect. The XML body is untouched.OWSExceptioncan setstatus_basedirectly in the class definition, or pass it as input parameter when raised for custom status code for a given specific case. The value can be any of the int status code, the HTTPException type, or an HTTPException instance.