crypto: serialize keys with alg-prefixed hex strings #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
from_bytes_string()
andto_bytes_string()
onPublicKey
andPrivateKey
, which look like the datalog syntax (ed25519/<hex bytes>
), so that the key algorithm is explicit.This will avoid confusions at program boundaries, when the keys must be read from strings (eg in biscuit-cli or when reading keys from environment variables).
I chose to implement it only on the top level structures (ie not in
ed25519
andp256
modules), and in new methods to avoid breaking existing code.