This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
List ZeroOneCoin (ZOC) #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Evydder
commented
May 31, 2018
Evydder
commented
- Official project URL: https://01coin.io/
- Official block explorer URL: https://explorer.01coin.io/
blabno
suggested changes
Jun 5, 2018
| import bisq.asset.Base58BitcoinAddressValidator; | ||
| import bisq.asset.NetworkParametersAdapter; | ||
|
|
||
| public class ZeroOneCoin extends Coin { |
There was a problem hiding this comment.
This file does not conform to Bisq code style.
|
Bisq code style applied, please squash those commits into one (reuse the same branch and PR). |
cbeams
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
ACK. As I've discussed elsewhere with @blabno, it's not necessary to squash commits made by reviewers. It's good for the record, and beneficial for everyone involved to see what those changes look like, so they can learn from them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.