This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
List Cryptonodes (CNMC) #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 26, 2018
ghost
commented
- Official project URL: https://www.cryptonodes.ch
- Official block explorer URL: http://explorer.cryptonodes.ch
cbeams
suggested changes
Jun 29, 2018
There was a problem hiding this comment.
NACK. Amend your commit comment so it reads the way https://docs.bisq.network/exchange/howto/list-asset.html#step-5-create-a-well-formed-git-commit says it should.
Force push the result. Do not create a new PR.
|
Nevermind my last comment. I accidentally merged this pull request anyway. So it's in now and will ship with v0.7.1. |
cbeams
added a commit
to cbeams/bisq-assets
that referenced
this pull request
Jun 29, 2018
Previously the implementation did not list a ticker symbol, but rather listed the asset name where the ticker symbol should have been. Now the ticker symbol is listed correctly. See bisq-network#50
|
sorry for that and ty |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.