Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post on cycle 9 results #343

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Conversation

m52go
Copy link
Contributor

@m52go m52go commented Feb 12, 2020

Note: deploy is failing because the post in this pull request includes a post_url link to the Q1 2020 post, which hasn't been merged yet, so the link cannot be found and the build process throws an exception.

Just need to make sure PR 342 is merged first, and this PR should build without error.

EDIT: rebased so it builds successfully, now that 342 is merged.

@m52go m52go requested a review from cbeams February 12, 2020 17:19
@m52go m52go force-pushed the add-cycle9-results branch from 351ffc7 to 7dcc407 Compare February 13, 2020 05:31
Copy link
Contributor

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I'm very glad we do these posts.

Do you plan to cross post to the @bisq-network/dao team (as I believe we discussed)? I think we discussed cross-posting the full text, but perhaps it's enough to post the link (I don't want to create busy work for you transcribing the markdown). My concern is simply that people don't have a reliable mechanism for getting notified via RSS, and that many contributors will miss out on these updates.

.editorconfig wasn't being respected.
@m52go
Copy link
Contributor Author

m52go commented Feb 13, 2020

Do you plan to cross post to the @bisq-network/dao team

Yes, can do it now just after merging. GitHub's discussions are formatted in Markdown too, so it's not a big deal. GitHub's flavor is only slightly different than whatever flavor it is Jekyll uses.

@m52go m52go merged commit 70fabdf into bisq-network:master Feb 13, 2020
@m52go m52go deleted the add-cycle9-results branch February 13, 2020 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants