Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use environment locale to select right locale and currency #1204

Closed
ripcurlx opened this issue Jan 16, 2018 · 2 comments
Closed

Use environment locale to select right locale and currency #1204

ripcurlx opened this issue Jan 16, 2018 · 2 comments
Assignees

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 16, 2018

At the moment the default environment locale is not used/set properly which causes every user to be defaulted to en_US. Every new user will experience the app in English with USD selected.

Steps to reproduce:

  • Have system settings set to e.g. de_AT
  • Start a clean Bisq installation

Expected Behavior:
On first startup of Bisq I expect the app to be in German and EUR selected as currency.

Actual Behavior:
The app starts in English and USD is selected.

@blabno
Copy link

blabno commented Feb 1, 2018

I'm taking this one.

@ManfredKarrer
Copy link
Contributor

I don't remember what the problems was but there have been issues when using the OS default locale. Thats why the following code is executed at the very start.

public class BisqAppMain extends BisqExecutable {
static {
// Need to set default locale initially otherwise we get problems at non-english OS
Locale.setDefault(new Locale("en", Locale.getDefault().getCountry()));

Should be fixed and investigated what was the issues if that code is not in place (just try it out).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants