Use environment locale to select right locale and currency

[blabno]

Fixes #1204

[ManfredKarrer]

Have you tested that with non en_US locales? I don't remember what was the issue but I think there have been an issue with not using en US here.

[blabno]

Yes, I've tested it with en_US. It selects:

• MainView currency price dropbox: BTC/USD
• Settings->Base currency: BTC
• Settings->Language: English
• Settings->Country: United States
• Settings->Preferred Currency: USD

I don't see any errors in logs.

[blabno]

Hm, although stuff works for this ticket, I've just realized that language is always overwritten with EN due to this:
https://github.com/bisq-network/exchange/blob/master/gui/src/main/java/io/bisq/gui/app/BisqAppMain.java#L37

[ManfredKarrer]

Yes there have been issues with NON English locales. Can you try to deactivate the code in https://github.com/bisq-network/exchange/blob/master/gui/src/main/java/io/bisq/gui/app/BisqAppMain.java#L37 and test with non English locales?

[blabno]

I did that with German and got German translation from the beginning. 1 lut 2018 22:01 "Manfred Karrer" <[email protected]> napisał(a):

…

Yes there have been issues with NON English locales. Can you try to deactivate the code in https://github.com/bisq- network/exchange/blob/master/gui/src/main/java/io/bisq/gui/ app/BisqAppMain.java#L37 and test with non English locales? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAaT2MWrLeE4msHtHJ_r9pfmqnojX5euks5tQiYWgaJpZM4R1lWT> .

[ManfredKarrer]

As far I remember it was some more subtle issue... damn I should have commented it more in details....
But we can change it, the issue will pop up during dev testing or at least at release testing. The next release will require a profound test cycle anyway.

[blabno]

Should we merge it then?

[ManfredKarrer]

It is missing the removal of the english locale setting at startup. Can you add that?

[blabno]

Removed setting default language to English at startup.