Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the MARKET/SPREAD tab, some listed cryptos don't have a description field #2189

Closed
ghost opened this issue Jan 2, 2019 · 4 comments
Closed

Comments

@ghost
Copy link

ghost commented Jan 2, 2019

v0.9.1/Debian
In the MARKET/SPREAD tab, some listed cryptos don't have a description field
eg N/A (BCH) , N/A (STEEM) , N/A (YTN)
Probably delisted cryptos.

If it's not too complicated (or dangerous), feel free to assign this issue to me.

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 7, 2019

@HarryMacfinned The classes for this assets were removed from the repository, which causes the N/A in the Spread view. As this will be a non issue as soon as all these single loitering offers are gone, I'll close this issue.

@ripcurlx ripcurlx closed this as completed Jan 7, 2019
@ghost
Copy link
Author

ghost commented Jan 8, 2019

@ripcurlx , thanks for answering,
However I wonder how those concerned offers will go by themselves ? Do you expect the makers to delete them ?
I have seen many cases with old offers lasting for months.
There are 5 such offers now in v0.9.2.

@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 23, 2019

@HarryMacfinned Feel free to add removed assets over time if you see new "N/A" appear.

final List<CryptoCurrency> currencies = new ArrayList<>();
currencies.add(new CryptoCurrency("BCH", "Bitcoin Cash"));
currencies.add(new CryptoCurrency("BCHC", "Bitcoin Clashic"));
currencies.add(new CryptoCurrency("ACH", "AchieveCoin"));
currencies.add(new CryptoCurrency("SC", "SpaceCash"));
currencies.add(new CryptoCurrency("PPI", "PiedPiper Coin"));
currencies.add(new CryptoCurrency("PEPECASH", "Pepe Cash"));
return currencies;
I didn't want to add and check for all assets that have been removed since the beginning, so I just added the ones where a open offer was available at the time of implementation.

@ghost
Copy link
Author

ghost commented Jan 24, 2019

Thanks for the precisions @ripcurlx
I'll have a look at this java piece of code.

@ghost ghost mentioned this issue Apr 9, 2019
@ghost ghost mentioned this issue Jul 9, 2019
fflo pushed a commit to fflo/bisq that referenced this issue Jul 13, 2019
add DAC + RDD to the list of removed assets.
Should solve bisq-network#2189 for those assets
I built the code and it seems to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant