Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust margin on "Don't show again" alert for translated strings #2681

Closed
huey735 opened this issue Apr 9, 2019 · 1 comment
Closed

Adjust margin on "Don't show again" alert for translated strings #2681

huey735 opened this issue Apr 9, 2019 · 1 comment
Assignees
@ripcurlx
Labels
in:gui

Comments

@huey735
Copy link
Contributor

huey735 commented Apr 9, 2019

Unfortunately due to the nature of translations, strings can vary in length from language to language. I have my adjusted some translations for harmony with the UI where possible, but some places just can't be helped.
Alerting about the security deposit function
alert
Alerting that I've accepted an offer
offeraccpted
@ripcurlx ripcurlx self-assigned this Apr 11, 2019
@ripcurlx
Copy link
Contributor

Yes, I the construction of the UI in the footer need to be changed. I saw this also in the German translation already.

ripcurlx added a commit to ripcurlx/bisq-desktop that referenced this issue Apr 11, 2019
@ripcurlx
Move DontShowAgainCheckbox into same HBox as buttons to prevent overl…
7a42708 
…apping. Fixes bisq-network#2681.
@ripcurlx ripcurlx mentioned this issue Apr 11, 2019
Closed
ripcurlx added a commit to ripcurlx/bisq-desktop that referenced this issue Apr 11, 2019
@ripcurlx
Move DontShowAgainCheckbox into same HBox as buttons to prevent overl…
a863bf6 
…apping. Fixes bisq-network#2681.
@ripcurlx ripcurlx mentioned this issue Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ripcurlx ripcurlx

Labels
in:gui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ripcurlx @huey735