Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode's Buy/Sell UI bubble text not clearly visible in v1.2.0 #3440

Closed
ghubstan opened this issue Oct 22, 2019 · 4 comments
Closed

Dark Mode's Buy/Sell UI bubble text not clearly visible in v1.2.0 #3440

ghubstan opened this issue Oct 22, 2019 · 4 comments
Labels
good first issue in:gui

Comments

@ghubstan
Copy link
Contributor

ghubstan commented Oct 22, 2019 •
edited
Loading

[How to Reproduce]

  1. Start Alice or Bob desktop
  2. Set dark mode
  3. Create buy or sell order
  4. Click (or hover over) any 'i' or 'eye' icon in any of the following windows

[Expected Results]
Bubble text is easy to read in dark mode.

[Actual Results]
Bubble text not easy to read in dark mode -- text should be darker color.
AdvancedOptionsText

This issue was discovered during v1.2.0 testing .
@ripcurlx
Copy link
Contributor

@wiz Could you please have a look at that? Thanks!

@ghubstan ghubstan mentioned this issue Oct 23, 2019
Closed
@objectorange
Copy link

Was this not fixed? It looks like it.

@wiz
Copy link
Contributor

wiz commented Jan 1, 2020

Yeah this was fixed by @ripcurlx in #3803

@wiz wiz removed their assignment Jan 1, 2020
@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 3, 2020

Closing as fixed in #3803.

@ripcurlx ripcurlx closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in:gui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ripcurlx @wiz @freimair @objectorange @ghubstan