Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dark mode styles #3803

Merged
merged 2 commits into from
Dec 19, 2019
Merged

Improve dark mode styles #3803

merged 2 commits into from
Dec 19, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Dec 18, 2019 •
edited
Loading

Fixes progress bar track issue and popover text readability issue in #3185.
Bildschirmfoto 2019-12-18 um 13 03 27

@ripcurlx ripcurlx requested a review from sqrrm as a code owner December 18, 2019 12:03
@ripcurlx ripcurlx requested a review from wiz December 18, 2019 12:04
wiz
wiz approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My hero! Your .popover class styling with !important hack fixes the 2 bugs

sqrrm
sqrrm approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@sqrrm sqrrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@sqrrm sqrrm merged commit 0efbe06 into bisq-network:master Dec 19, 2019
@wiz
Copy link
Contributor

wiz commented Dec 20, 2019

Unfortunately after more testing I noticed that other progress bars were affected, that shouldn't have been - I will make a new PR
Screen Shot 2019-12-21 at 3 03 33
Screen Shot 2019-12-20 at 2 31 26
Screen Shot 2019-12-21 at 3 04 51
Screen Shot 2019-12-21 at 3 05 04

@wiz wiz mentioned this pull request Jan 1, 2020
Closed
@ripcurlx ripcurlx added this to the v1.2.5 milestone Jan 2, 2020
@sqrrm sqrrm mentioned this pull request Jan 13, 2020
Closed
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
@ripcurlx ripcurlx deleted the fix-dark-mode-issues branch July 16, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiz wiz wiz approved these changes

@sqrrm sqrrm sqrrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.5
Development

Successfully merging this pull request may close these issues.
3 participants
@ripcurlx @wiz @sqrrm