Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE when duplicating offer if the account does not exist. #6232

Closed
ghost opened this issue May 31, 2022 · 1 comment · Fixed by #6233
Closed

NPE when duplicating offer if the account does not exist. #6232

ghost opened this issue May 31, 2022 · 1 comment · Fixed by #6233

Comments

@ghost
Copy link

ghost commented May 31, 2022

Description

Go to Portfolio -> History. Click on the icon to duplicate one of your previous offers. If the account of that offer is not available, a NPE error box will be displayed.

Version

1.9.1, probably earlier versions too.

Expected behaviour

  • If possible, clear the account selection which would make the user choose an account to enter the offer.

Screenshots

image

May-31 11:25:48.280 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.NullPointerException 
May-31 11:25:48.293 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.NullPointerException
    at bisq.desktop.main.offer.bisq_v1.MutableOfferDataModel.isUsingHalCashAccount(MutableOfferDataModel.java:804)
    at bisq.desktop.main.offer.bisq_v1.MutableOfferViewModel.setAmountToModel(MutableOfferViewModel.java:1176)
    at bisq.desktop.main.offer.bisq_v1.MutableOfferViewModel.onFocusOutAmountTextField(MutableOfferViewModel.java:724)
    at bisq.desktop.main.offer.bisq_v1.MutableOfferViewModel.triggerFocusOutOnAmountFields(MutableOfferViewModel.java:861)
    at bisq.desktop.main.portfolio.duplicateoffer.DuplicateOfferViewModel.activate(DuplicateOfferViewModel.java:89)
    at bisq.desktop.common.model.ActivatableWithDataModel._activate(ActivatableWithDataModel.java:29)
    at bisq.desktop.common.view.ActivatableViewAndModel.lambda$prepareInitialize$0(ActivatableViewAndModel.java:37)
@ripcurlx
Copy link
Contributor

ripcurlx commented Jun 1, 2022

@xyzmaker123 Could you take this one? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant