-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE when duplicate offer with deleted account #6233
Conversation
The fix is an improvement, however an NPE still happens if no account is available.
|
@jmacxx I fixed it by hiding "duplicate offer" button when no account exists |
Still getting an NPE, I think there is a "hidden" account for BSQ swaps causing trouble. Perhaps if that was excluded from the count everything would work as planned. No altcoin accounts: Portfolio history with the duplicate icon: Count of non-fiat accounts is in fact 1.
Log:
|
I created more advanced logic for handling those edge case scenarios. Excluding BSQ Swap account wasn't enough, because it disallowed duplication of BSQ Swap offer when no altcoin account existed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK - based on #6233 (review)
Fixes #6232
Description:
When account doesn't exists anymore standard logic from
initWithData
is used