-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Blur (BLUR) #1723
List Blur (BLUR) #1723
Conversation
Originally, this PR was re-submitted with modifications to include the recently merged CryptonoteAddressValidator. But, those are failing for Blur addresses. However, they work properly on https://xmr.llcoins.net/addresstests.html. I'm looking into what the issue is, and will submit a separate PR if it is due to the checksum, with a solution. |
331be55
to
7f324f2
Compare
@blur-network Could I get the original class definition as well, so that I could try fixing the Base58 regex validation? |
@Technohacker Definitely. Will send over as soon as I get back at a workstation. The error seemed to be the result of public BLUR addresses being 97 characters (despite only a two-character prefix). The code appears to expect a 96 character string instead. Prefix is ‘bL’ (0x1e4d in hex, 7757 decimal) which I believe results in ‘c3dc’ encoded but I’m not at a computer to ensure the accuracy of the last bit. |
@Technohacker You can find the commit from that previous PR here: 331be55 Sorry for the delay on reply. Please do let me know if there's an error in my code that I'm just not catching, there... But the build fails on Line 31 of BlurTest.java |
7f324f2
to
7260de2
Compare
@blur-network Thanks! I'll see what I can do :) |
@Technohacker that offer to help, extends to you too. Wouldn't mind helping out with the validation code. Also wouldn't want to start working on it without knowing where your efforts are at, so as not to repeat work that is already completed. |
@blur-network Unfortunately I was stuck with other work so I couldn't get anything done 😅 |
@Technohacker Discord is my go-to. I’ve also got telegram.. |
69191dc
to
7acd03d
Compare
7acd03d
to
2b39e60
Compare
Changes have been force-pushed to also validate Two-character prefixes (Blur, Aeon, etc... ) on public addresses & subaddresses, using CryptonoteAddressValidator |
I presume this will need ACKed again @blabno |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Edit(10/13): This PR includes modifications to the standard Cryptonote address validator. The validator, with these changes, will now be able to support one and two-character prefixes for standard cryptonote addresses & subaddresses.
This is a resubmission of a previous PR located at: bisq-network/bisq-assets/pull/58
That submission had been ACKed by @blabno
Official project URL: https://blur.cash
Official block explorer URL: http://explorer.blur.cash
Additional: The Blur CLI/GUI wallets issue a transaction private key, similar to Monero. Using a transaction private key, the transaction's hash, and a recipient address, arbitrators can verify transactions using the Blur Network Transaction Viewer (https://blur.cash/#tx-viewer).
Two additional pull requests were submitted for a pop-up explaining the requirements to trade BLUR on Bisq. That code has already been merged.
For reference, those merged PRs can be found here:
/pull/1617
bisq-network/bisq-core/pull/142