Small improvements/fixes #1728
Merged
Small improvements/fixes #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If user press cmd+t it switches to DEBUG log level for the tor network library. If the user press it again it switch back to WARN level. - If there is a connection startup timeout where we display the Tor network settings popup we switch log level as well to DEBUG.
- Rename excludeBsqUnlessDaoTradingIsActive to isNotBsqOrBsqTradingActivated to make it more clear - Fix wong check with getDefaultBaseCurrencyNetwork (use getBaseCurrencyNetwork instead) - Add comment to support network check or Tokens
|
No idea why Travis build fails, my local build works (incl. tests). Cannot open Travis page... |
- If both verifiedOpReturnType and opReturnTypeCandidate are empty we got an error logged. We change that so that only of both are present but not matching we log a warning.
- Fix wrong start height - Improve logging
ripcurlx
suggested changes
Sep 27, 2018
|
Ah thanks. Hm... somehow my test run succeeded before, but now they failed as well... Fixed with latest commits. |
ripcurlx
approved these changes
Sep 27, 2018
|
utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.