Dao fix majorityvote issue #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to add any valid vote reveal tx / blind vote tx pair for the majority hash calculation even if the blind vote payload is missing as that could be relevant for the majority hash calculation. We add an empty ballotList and meritList in such cases.
ManfredKarrer
changed the title
|
Needs more testing before merge. |
We had 2 times the onParseTxsComplete called in the version before
To avoid empty handlers I have set all methods to default so the client code implements only the used one. Move handler code from onNewBlockHeight to onParseTxsCompleteAfterBatchProcessing to avoid too much UI updates while parsing.
ManfredKarrer
changed the title
|
@sqrrm I have tested now with different scenarios with blind vote missing, ignore merit for majorit hash case,... Could you give it a critical review and test cycle as well? |
# Conflicts: # desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java
|
I am looking at this but it will take a while as it's rather complicated. @ripcurlx hope to be done before the next release as I think this is quite important to get in. |
ripcurlx
reviewed
Feb 8, 2019
desktop/src/main/java/bisq/desktop/main/dao/governance/result/VoteResultView.java
Outdated
Show resolved
Hide resolved
sqrrm
approved these changes
Feb 8, 2019
Refactor voteresult to make it easier to understand
|
@sqrrm I will merge to not delay release, but please go on testing, its a very critical PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2362