Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List multiple stable coins #2395

Merged
merged 3 commits into from
Feb 12, 2019
Merged

List multiple stable coins #2395

merged 3 commits into from
Feb 12, 2019

Conversation

ripcurlx
Copy link
Contributor

@ripcurlx ripcurlx commented Feb 8, 2019 •
edited
Loading

- Tether (ERC-20 based token)
- Official project URL: https://tether.to/
- Official block explorer URL: https://etherscan.io/token/0xdac17f958d2ee523a2206206994597c13d831ec7

Fixes #2369.

@ripcurlx ripcurlx changed the title - Tether (ERC-20 based token) - Official project URL: https://tether.to/ - Official block explorer URL: https://etherscan.io/token/0xdac17f958d2ee523a2206206994597c13d831ec7 - DAI (ERC-20 based token) - Official project URL: https://makerdao.com/en - Official block explorer URL: https://etherscan.io/token/0x89d24a6b4ccb1b6faa2625fe562bdd9a23260359 - TrueUSD (ERC-20 based token) - Official project URL: https://www.trusttoken.com/trueusd/ - Official block explorer URL: https://etherscan.io/token/0x0000000000085d4780B73119b644AE5ecd22b376 - USD Coin (ERC-20 based token) - Official project URL: https://www.centre.io/usdc - Official block explorer URL: https://etherscan.io/token/0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48 List multiple stable coins Feb 8, 2019
@ripcurlx ripcurlx added this to the v0.9.4 milestone Feb 8, 2019
@ManfredKarrer ManfredKarrer requested a review from blabno February 10, 2019 03:33
blabno
blabno approved these changes Feb 10, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

ManfredKarrer
ManfredKarrer reviewed Feb 11, 2019
View reviewed changes
Copy link
Contributor

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is tether a Erc20Token? I thought its on OMNI....

@ripcurlx
Copy link
Contributor Author

Is tether a Erc20Token? I thought its on OMNI....

@ManfredKarrer There are two implementations: OMNI and ERC-20. As mentioned in #2369 I'm not sure if it would cause confusion if we support both address types.

@ripcurlx ripcurlx force-pushed the add-multiple-stablecoins branch from 3400428 to 3a39e22 Compare February 12, 2019 13:56
@ripcurlx
Copy link
Contributor Author

I removed Tether for now because of the duplicate implementation with Omni and ERC-20.

@ripcurlx ripcurlx merged commit df753ea into bisq-network:master Feb 12, 2019
@aejontargaryen
Copy link
Contributor

https://www.youtube.com/watch?v=5KXHgh2rTTw?t=783

@ripcurlx ripcurlx mentioned this pull request Feb 27, 2019
Closed
@ripcurlx ripcurlx deleted the add-multiple-stablecoins branch December 18, 2019 08:32
@flix1 flix1 mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer left review comments

@blabno blabno blabno approved these changes

Assignees

@blabno blabno

Labels
in:altcoins
Projects
None yet
Milestone
v0.9.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ripcurlx @aejontargaryen @blabno @ManfredKarrer