Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to trade history #2752

Merged
merged 3 commits into from
Apr 27, 2019
Merged

Add filter to trade history #2752

merged 3 commits into from
Apr 27, 2019

Conversation

ManfredKarrer
Copy link
Contributor

No description provided.

@ManfredKarrer
Show readable data in offer
307bf73
@ManfredKarrer
Add filter box to trade history
c25c1ca 
Can filter by onion address, date string, trade id and
payment details data.
@ManfredKarrer ManfredKarrer requested a review from ripcurlx as a code owner April 20, 2019 01:38
@ManfredKarrer ManfredKarrer added this to the v1.1.0 milestone Apr 20, 2019
@ManfredKarrer ManfredKarrer requested a review from sqrrm April 24, 2019 23:52
ripcurlx
ripcurlx approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - just added a prompt text for filter textfield to give the user an idea what she can filter for

@ManfredKarrer
Copy link
Contributor Author

Local build works, so failure above seems to be Travis issue

@ManfredKarrer ManfredKarrer merged commit b1a8429 into bisq-network:master Apr 27, 2019
@ManfredKarrer ManfredKarrer deleted the add-filter-to-trade-history branch April 27, 2019 20:53
@ripcurlx ripcurlx mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
in:gui in:trade-process
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ManfredKarrer @ripcurlx