Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various CSS fixes for v1.1.6 #3168

Merged
merged 2 commits into from
Sep 2, 2019
Merged

Various CSS fixes for v1.1.6 #3168

merged 2 commits into from
Sep 2, 2019

Conversation

wiz
Copy link
Contributor

@wiz wiz commented Aug 30, 2019 •
edited
Loading

Light Theme regressions

  • Fix wrong shade of gray used as background color on grid-pane

Screen Shot 2019-08-31 at 2 17 28

  • Fix green scrollbars

Screen Shot 2019-08-31 at 23 46 40

Dark Theme fixes

  • Fix dark text on dark background in text field on grid-pane

Screen Shot 2019-08-31 at 2 20 20

  • Fix dark text on dark background in table columns

Screen Shot 2019-08-31 at 2 18 16

  • Fix dark icons on dark background

Screen Shot 2019-08-31 at 2 30 52

Screen Shot 2019-08-31 at 2 34 56

  • Fix action buttons being too dark on dark background

Screen Shot 2019-08-31 at 2 30 38

  • Fix placeholder text inside text input boxes being too light

Screen Shot 2019-08-31 at 2 33 06

Screen Shot 2019-08-31 at 2 32 13

  • Fix selected row in table view not being hightlighted

Screen Shot 2019-08-31 at 2 43 47

  • Fix new dropdown box styling (was implemented before CSS split)

Screen Shot 2019-08-31 at 3 52 54

  • Fix double tooltips on DAO bond table view

Screen Shot 2019-08-31 at 4 03 55

  • Fix password dark on dark

Screen Shot 2019-08-31 at 19 04 51

  • Label above pull-down is dark on dark

Screen Shot 2019-08-31 at 19 10 01

@devinbileck
Copy link
Member

devinbileck commented Aug 30, 2019 •
edited
Loading

  • The chat window needs some updates for dark mode.
    image
  • The progress bars in the bottom status bar are visible when they should not be in dark mode (i.e when synced/connected).
    Dark mode:
    image
    Light mode:
    image
  • Buttons do not show a background highlight in dark mode so it is not obvious they are a button until you move the mouse over it (they have a hover effect to change the highlight).
    Dark mode:
    image
    Light mode:
    image
  • When clicking to sort a column in any view, the grid temporarily uses the light theme until you click anywhere.
    image
  • When showing dispute details and viewing contract details in JSON format, it opens a window that is not styled.
    image
    And I just realized you can bring up a similar unstyled window when double clicking a chat message.
    image
  • Fix the text in the chat bubbles and edit field in the support/arbitration section:
    image
  • Calendar picker for selecting wallet date when restoring from seed words:
    image
  • Viewing proposal results/details:
    image

@wiz
Copy link
Contributor Author

wiz commented Aug 31, 2019

@devinbileck Thanks for your testing! It seems that some of these UI elements, for example the calendar and the chat window, are not currently styled on the light theme, and while this looks fine on the light theme, they really stick out as "bugs" on the dark theme since they are not styled at all. I will do my best to fix everything this weekend 😅

@wiz wiz force-pushed the fifty-shades-of-gray branch 5 times, most recently from 0da293f to 1031c43 Compare September 1, 2019 00:05
@wiz wiz marked this pull request as ready for review September 1, 2019 00:41
@wiz wiz requested review from ripcurlx and sqrrm as code owners September 1, 2019 00:41
@wiz wiz changed the title [WIP] Various CSS fixes for v1.1.6 Various CSS fixes for v1.1.6 Sep 1, 2019
@wiz wiz force-pushed the fifty-shades-of-gray branch from 1031c43 to d9dbbd1 Compare September 1, 2019 13:03
@wiz wiz force-pushed the fifty-shades-of-gray branch from d9dbbd1 to 5209c2f Compare September 1, 2019 13:10
chimp1984
chimp1984 approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside small commeny utACK for that commit

@freimair
Copy link
Contributor

freimair commented Sep 1, 2019

is #1263 tackled by this PR as well?

@wiz
Copy link
Contributor Author

wiz commented Sep 1, 2019

@freimair This PR doesn't relate to that, but can you confirm #1263 is still reproducible on master? I tested macos both light/dark OS setting and after restarting Bisq it loads the correct visible menu tray icon.
Screen Shot 2019-09-01 at 23 23 21

@wiz
Copy link
Contributor Author

wiz commented Sep 1, 2019

Oh, sorry I misunderstood - I thought you meant tray icon, yes it seems someone has disabled the menu bar changing to dark mode so the issue doesn't reproduce. I can fix that in a separate PR.

@wiz wiz force-pushed the fifty-shades-of-gray branch 2 times, most recently from 3399b90 to b91d803 Compare September 1, 2019 15:19
wiz added 2 commits September 2, 2019 05:08
@wiz
Move CSS theme code into its own class, apply CSS theme to all scenes
04d073f
@wiz
Multiple CSS bugfixes for light/dark themes
6cef6e0 
[Light Theme]
* Fix wrong shade of gray used as background color on grid-pane
* Fix green scrollbars, should be gray as before

[Dark Theme]
* Fix action buttons being too dark on dark background
* Fix combo-box-editor referencing old CSS class names
* Fix incorrect shades of gray used for wizard item background
* Set font-smoothing to gray method

* Style javafx's main color palette, which fixes below issues:
* Fix dark text on dark background in text field on grid-pane
* Fix password entry input field dark on dark
* Fix trade chat bubbles and text
* Fix calendar date picker
* Fix viewing DAO proposal results
@wiz wiz force-pushed the fifty-shades-of-gray branch from b91d803 to 6cef6e0 Compare September 1, 2019 20:14
ripcurlx
ripcurlx approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 0e21ffb into bisq-network:master Sep 2, 2019
@ripcurlx ripcurlx mentioned this pull request Sep 6, 2019
Closed
@wiz wiz mentioned this pull request Sep 9, 2019
Closed
@wiz wiz deleted the fifty-shades-of-gray branch January 9, 2020 23:02
@ripcurlx ripcurlx mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@chimp1984 chimp1984 chimp1984 approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wiz @devinbileck @freimair @ripcurlx @chimp1984