Fee validation leniency using old DAO param values #5347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Bisq clients are stuck on an invalid DAO state and are paying fees on an old schedule.
Per #5329 (comment) : a paid fee will be considered valid if it can be derived from any of the DAO parameter changelist.
After implementing this change, the OfferBook discrepancies listed in #5329 are reduced to zero.
The essence of the leniency check is this: