Enforce inclusion of TradeLimits for headless apps #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripcurlx
previously approved these changes
Nov 23, 2021
|
@ripcurlx Please ignore the Codacy complaints. |
PaymentMethod use an instance of TradeLimits and expect that it has been injected, which is the case for desktop but not for headless apps, so we enforce injection in the app base classes used for headless apps. The validation of trade statistics use a method in PaymentMethod where that dependency is required. Tha hack how the PaymentMethod use TradeLimits is not nice, but would require more effort for refactoring.
chimp1984
force-pushed
the
add-missing-dependency
branch
from
31c2d62 to
9c18899
Compare
ripcurlx
added a commit
to ripcurlx/bisq-desktop
that referenced
this pull request
Nov 24, 2021
…as cherry-picked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentMethod use an instance of TradeLimits and expect that it
has been injected, which is the case for desktop but not for
headless apps, so we enforce injection in the app base classes
used for headless apps.
The validation of trade statistics use a method in PaymentMethod where that
dependency is required.
Tha hack how the PaymentMethod use TradeLimits is not nice, but
would require more effort for refactoring.