Improve user experience once mediation has been accepted by both parties #5870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitions to Trade Step 4 (previously it would close/remove the trade).
ghost
marked this pull request as draft
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
|
I agree that the withdraw to external wallet convenience option might be confusing for new users. But as this is a bigger change in the trade flow, I'd appreciate an ACK from @chimp1984 or @sqrrm as well before merging. |
|
@jmacxx I think we should also rename the wording of those two popups Before I'll push this changes from my local branch. |
ripcurlx
previously approved these changes
Jan 11, 2022
|
I'm still merging this PR although as Codacy has permission issues (again) |
|
@jmacxx thanks for this. Could something like this be done for arbitration? I think currently when arbitration is closed the trade just disappears? I might be wrong though. |
|
This PR had the same effect for both mediated & arbitrated trades, they wait until the user presses close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5546
Transitions to Trade Step 4 (previously it would close/remove the trade).