Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Security: Use Github actions via sha1 (not tags) and keep them updated via dependabot #5943

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

dbast
Copy link
Contributor

@dbast dbast commented Dec 30, 2021

Tags are mutable and can change unexpectedly. Referencing actions via sha1 is more secure in that regard. Dependabot helps to automatically update to newer versions without the need to manually deal with sha1s.

Merging the PR opens update PRs similar to those shown here https://github.com/dbast/bisq/pulls

Each update PR lists the according changes to each action and allows giving instructions to dependabot via e.g. @dependabot ignore this major version.

…ndabot

Tags are mutable and can change unexpectedly. Referencing actions via sha1
is more secure in that regard. Dependabot helps to automatically update to
newer versions.
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - reviewed the commit hashes used for each action. It is true that Github seems to update their major version action tags all the time.

@ripcurlx ripcurlx added this to the v1.8.1 milestone Jan 3, 2022
@ripcurlx ripcurlx merged commit ec42d10 into bisq-network:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants