-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature enabling log file upload to mediators #5953
Conversation
Hi @jmacxx looks great. I think this will be really useful. Please can you send a screenshot of the initial dispute screen for the user where the button Please can you let me know:
|
Not at the moment, but if this feature is successful it should be easy enough to enable for the arbitrator. I need to think about that a bit..
Log files referencing the tradeId will be added to the zip archive and sent. Tests on Tor have been in the order of a 1.5 minutes for 6 log files (zip size 7Mb). Most disputes are likely to only include a couple of log files and that takes about 30 seconds.
Yes, see screenshot -> |
@jmacxx I just tried to send my log files on macOS on Regtest with following exception:
|
I guess it is the path issue again we had for the block file loading already. |
|
Fixed by replacing any space with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK - Tested it on Regtest with macOS Moneterey
I'm still merging this PR although as Codacy has permission issues (again) |
Closes #5906
@pazza83 asked for the process of submitting log files to be made easier. The solution presented here is basically a click and send option to transmit appropriate log files to a dispute's Mediator.
Send Log Files
.Send
.Screenshots:
Mediator notification:
Mediator's received logs:
Implementation notes:
Testing notes: