Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn and prompt for password before showing wallet keys #6021

Merged
merged 1 commit into from Feb 7, 2022
Merged

Warn and prompt for password before showing wallet keys #6021

merged 1 commit into from Feb 7, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2022

Fixes #6006

image

image

image

@w0000000t 👀

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - code changes are looking fine 👍

@ripcurlx ripcurlx added this to the v1.8.3 milestone Feb 7, 2022
@ripcurlx ripcurlx merged commit 910d322 into bisq-network:master Feb 7, 2022
@ghost ghost mentioned this pull request Feb 21, 2022
@pazza83
Copy link

pazza83 commented Mar 12, 2022

Hi @jmacxx thanks works well for wallet details.

Does a password prompt show for:

  • Withdrawing from emergency BTC or BSQ wallet?
  • Submitting a DAO proposal?

@ghost ghost deleted the fix_issue_6006 branch October 18, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet private keys shown without requesting password
2 participants