Fix issue selecting specific BSQ UTXO for send. #6040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BisqDefaultCoinSelector is invoked multiple times when a transaction is being built. Problem was that the coin selection was being reset within, ultimately leading to coin selection being completely ignored. Solution is to reset the selection after the transaction has been built. The UI for selecting UTXO inputs was being resized to the number of UTXO available, which caused problems when there is a large UTXO set. Solution is to size the UI to accomodate 3 to 15 rows, which provides a reasonable screen display and a scrollbar is provided for the case of a large UTXO set.
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6023
UI Issue:
Transaction issue:
BisqDefaultCoinSelectoris invoked multiple times when a transaction is being built. Problem was that the coin selection was being reset within, ultimately leading to coin selection being completely ignored. Solution is to keep the coin selection, resetting after the transaction has been built.Screenshots
example no UTXO
example 2 utxo
fabricated example 100 utxo with scrollbar