Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude persistedAccountName from API payment acct json forms #6098

Conversation

ghubstan
Copy link
Contributor

@ghubstan ghubstan commented Mar 9, 2022

This recently added field (1da71f6) is automatically set inside PaymentAccount. It should not be included in the payment acct json forms used by API clients.

Based on branch master.

This recently added field is automatically set inside PaymentAccount.
It should not be included in the payment acct json forms used by API clients.

Based on branch `master`.
@ripcurlx ripcurlx added this to the v1.8.5 milestone Mar 9, 2022
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 8449139 into bisq-network:master Mar 10, 2022
@ghubstan ghubstan deleted the exclude-persistedAccountName-from-json-form branch March 10, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants