Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bitcoin Core v22 RPC for JSON export #6123

Merged
merged 3 commits into from Apr 4, 2022
Merged

Support Bitcoin Core v22 RPC for JSON export #6123

merged 3 commits into from Apr 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2022

Fixes #6119
Transaction address not provided from bitcoind v22 RPC call.
Get address using BitcoinJ to decode scriptPubKey.

@chimp1984

@ripcurlx ripcurlx requested a review from chimp1984 March 29, 2022 15:02
@ripcurlx ripcurlx added this to the v1.8.5 milestone Mar 29, 2022
chimp1984
chimp1984 previously approved these changes Mar 29, 2022
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Tested with Bitcoin Core 19 and 22 and tested basic DAO use cases.

Left a comment, not sure if that is relevant to address.

@ghost
Copy link
Author

ghost commented Apr 3, 2022

Testing:

  • PRE: using v21 bitcoind or earlier.
  • Setup genesis DAO environment for Alice/Bob.
  • Go through 1 cycle with 2 comp requests & 2 votes.
  • Make a BSQ transfer from Bob -> Alice.
  • Shutdown, take a bitcoind chain snapshot/copy for future test (label it as v21).
  • Run JSON seednode export using v21 bitcoind and set the JSON directory aside (marked as v21_run1).
  • Repeat above step and set the JSON directory aside (marked as v21_run2).
  • Verify JSON directories match using meld: v21_run1 == v21_run2.
  • Switch bitcoind to v22 (POST environment).
  • Run JSON seednode export using v22 bitcoind and set the JSON directory aside (marked as v22_run1).
  • Repeat above step and set the JSON directory aside (marked as v22_run2).
  • Verify JSON directories match using meld: v22_run1 == v22_run2.
  • Compare JSON directories using meld: v21_run1 == v22_run1.

@ghost
Copy link
Author

ghost commented Apr 3, 2022

This PRE/POST test ☝️ is successful with the revised code solution 60db944. If the code is acceptable I can redo the more laborious mainnet test.

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - based on #6123 (review) and testing by @jmacxx

@ripcurlx ripcurlx merged commit 7aec070 into bisq-network:master Apr 4, 2022
@ghost ghost mentioned this pull request Apr 26, 2022
@ghost ghost deleted the fix_issue_6119 branch October 18, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitcoin Core v22 deprecated addresses is not handled
2 participants