Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check failed trades for sensitive data purge. #6132

Merged
merged 1 commit into from Apr 5, 2022
Merged

Check failed trades for sensitive data purge. #6132

merged 1 commit into from Apr 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 4, 2022

Follow up to #6001.

A user in bisq.community mentioned that failed trades can also contain sensitive data, so we should check them for having the data purged after the relevant amount of time. Previously only trades which reached closed status were considered.

INFO  bisq.core.app.BisqSetup: initDomainServices 
INFO  b.c.s.dispute.DisputeManager: ArbitrationManager checking closed disputes eligibility for having sensitive data cleared 
INFO  b.c.s.dispute.DisputeManager: MediationManager checking closed disputes eligibility for having sensitive data cleared 
INFO  b.c.s.dispute.DisputeManager: RefundManager checking closed disputes eligibility for having sensitive data cleared 
INFO  b.c.t.ClosedTradableManager: checking closed trades eligibility for having sensitive data cleared 
INFO  b.c.t.b.FailedTradesManager: checking failed trades eligibility for having sensitive data cleared 

Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Code changes are looking fine

@ripcurlx ripcurlx added this to the v1.9.0 milestone Apr 5, 2022
@ripcurlx ripcurlx merged commit 3f02d52 into bisq-network:master Apr 5, 2022
@ghost ghost mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant