Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the avatar tradecount tag to include BSQ Swap trades. #6134

Merged
merged 1 commit into from Apr 7, 2022
Merged

Fix the avatar tradecount tag to include BSQ Swap trades. #6134

merged 1 commit into from Apr 7, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2022

The counter shown on a peer's avatar indicates how many trades you have done with that peer. BSQ swaps are currently not reflected in that count, so if you were looking on a peer avatar it would indicate either:

  • that you have not traded with that peer (even if you have done BSQ swaps with them), or
  • that you have traded with them 'n' times, representing the number of non-BSQ swap trades.

This PR fixes the issue by counting the number of regular trades and BSQ swap trades.

@ripcurlx ripcurlx added this to the v1.9.0 milestone Apr 7, 2022
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 2988061 into bisq-network:master Apr 7, 2022
@ghost ghost mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant