Improve xmr proof service

[chimp1984]

Fixes some issues brought up by kayabanerve

[ripcurlx]

@jmacxx Could you please review this PR? Thanks!

[ghost]

@ripcurlx yes, I am in process of reviewing/testing the code. Will let you know ASAP.

This popup text could probably use some revision from yourself / @m52go / @w0000000t to make it more understandable. It is shown at startup (only users with XMR accounts).

[ghost]

ACK
I tested mainly the subaddress generation - works fine for me.

[ripcurlx]

utACK - based on #6217 (review)

[w0000000t]

@ripcurlx yes, I am in process of reviewing/testing the code. Will let you know ASAP.

This popup text could probably use some revision from yourself / @m52go / @w0000000t to make it more understandable. It is shown at startup (only users with XMR accounts).

I thought I had replied already, sorry for the delay! I probably left the browser tab hanging and it went lost.
What I wrote the last time was to make the popup text shorter and more effective, like so:

WARNING
After changing data directory you must also change XMR wallet and address for security reasons [1]

[ghost]

@w0000000t thanks that looks good to me. How about this revision:

Notice for XMR users
If changing data directory you must also change XMR wallet and address for security reasons [1]
Read about why it's a good idea to switch to a new data directory every so often. [2]

[1] https://www.getmonero.org/2018/09/25/a-post-mortum-of-the-burning-bug.html
[2] https://bisq.wiki/Switching_to_a_new_data_directory

[w0000000t]

The amount of text increased, but likewise for information density, I am cool with it

[w0000000t]

I am currently testing this, and it didn't show on startup for me, or at least I cannot be 100% sure it didn't show when starting 1.9.3 testing instance with existing data directory with existing XMR accounts as I did close the popups quite shortly thereafter 😅
But I used the arbitrator instance, which had no existing XMR accounts, to create an XMR account and restart it, and this popup didn't show.

[ghost]

The popup moved to Account menu: #6236 (comment)