qt: Remove redundant BitcoinGUI::setTrayIconVisible

The removed BitcoinGUI::setTrayIconVisible just duplicates QSystemTrayIcon::setVisible.
bitcoin-core · Oct 24, 2020 · a124ee7 · a124ee7
1 parent 87e38a6
commit a124ee7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
@@ -615,10 +615,10 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH
         OptionsModel* optionsModel = _clientModel->getOptionsModel();
         if (optionsModel && trayIcon) {
             // be aware of the tray icon disable state change reported by the OptionsModel object.
-            connect(optionsModel, &OptionsModel::showTrayIconChanged, this, &BitcoinGUI::setTrayIconVisible);
+            connect(optionsModel, &OptionsModel::showTrayIconChanged, trayIcon, &QSystemTrayIcon::setVisible);
 
             // initialize the disable state of the tray icon with the current value in the model.
-            setTrayIconVisible(optionsModel->getShowTrayIcon());
+            trayIcon->setVisible(optionsModel->getShowTrayIcon());
         }
     } else {
         // Disable possibility to show main window via action
@@ -1387,13 +1387,6 @@ void BitcoinGUI::showProgress(const QString &title, int nProgress)
     }
 }
 
-void BitcoinGUI::setTrayIconVisible(bool show_tray_con)
-{
-    if (trayIcon) {
-        trayIcon->setVisible(show_tray_con);
-    }
-}
-
 void BitcoinGUI::showModalOverlay()
 {
     if (modalOverlay && (progressBar->isVisible() || modalOverlay->isLayerVisible()))

diff --git a/src/qt/bitcoingui.h b/src/qt/bitcoingui.h
@@ -317,9 +317,6 @@ public Q_SLOTS:
     /** Show progress dialog e.g. for verifychain */
     void showProgress(const QString &title, int nProgress);
 
-    /** When showTrayIcon setting is changed in OptionsModel show or hide the icon accordingly. */
-    void setTrayIconVisible(bool);
-
     void showModalOverlay();
 };