Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a 'UI/UX' label for GUI related design issues #44

Closed
Bosch-0 opened this issue Aug 5, 2020 · 4 comments
Closed

Create a 'UI/UX' label for GUI related design issues #44

Bosch-0 opened this issue Aug 5, 2020 · 4 comments
Labels
Feature

Comments

@Bosch-0
Copy link

Bosch-0 commented Aug 5, 2020 •
edited
Loading

With initiatives such as Bitcoin Design and square crypto grants being offered for Bitcoin designers, I think its important to have a UI/UX label for the likely new wave of designers entering the space in the coming years.

Design does not mean a 'fancy GUI', but a more usable and intuitive GUI. Good design means good usability, good usability is security.
@Bosch-0 Bosch-0 added the Feature label Aug 5, 2020
@laanwj
Copy link
Member

laanwj commented Aug 5, 2020

Concept ACK however the whole repository is called "gui", I don't hink having a UI/UX label is good UX 😄 . Maybe just "Design"?

@Bosch-0
Copy link
Author

Bosch-0 commented Aug 5, 2020

Design could relate to technical design whereas UI/UX is more specific, I don't see how its a bad label?

This might be a noob question but what does ACK mean? ;)

@laanwj
Copy link
Member

laanwj commented Aug 5, 2020

This might be a noob question but what does ACK mean? ;)

See here https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#peer-review

@jonatack
Copy link
Member

jonatack commented Aug 5, 2020 •
edited
Loading

This might be a noob question but what does ACK mean? ;)

See:

@Bosch-0 Bosch-0 closed this as completed Sep 28, 2020
fanquake added a commit that referenced this issue Oct 20, 2021
@fanquake
Squashed 'src/univalue/' changes from 98fadc0909..a44caf65fe
9b49ed6 
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues
135254331e Import fixes for sanitizer reported issues
d5fb86940e refactor: use c++11 range based for loop in checkObject
ff9c379304 refactor: Use nullptr (c++11) instead of NULL
08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support
66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus
808d487292 ci: travis -> cirrus
c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration
4a5b0a1c65 build: Move source entries out to sources.mk
6c7d94b33c build: cleanup wonky gen usage
a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23
f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD
1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix
92bdd11f0b univalue_write: remove unneeded sstream.h include
ffb621c130 Merge pull request #56 from drodil/remove_sstream_header
f33acf9fe8 Merge commit '7890db9~' into HEAD
66e0adec4d Remove unnecessary sstream header from univalue.h
88967f6586 Version 1.0.4
1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool
72392fb227 [tests] test pushKV for boolean values
c23132bcf4 Pushing boolean value to univalue correctly
81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS
b17634ef24 Update URLs to MIT license.
88ab64f6b5 Merge pull request #46 from jasonbcox/master
35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit
420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test

git-subtree-dir: src/univalue
git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laanwj @jonatack @Bosch-0