scripted-diff: Use Courier New as tabular figures font in Overview page #207
Conversation
-BEGIN VERIFY SCRIPT- sed -i 's/Monospace/Courier New/' src/qt/forms/overviewpage.ui -END VERIFY SCRIPT-
|
NACK forcing a specific font. We have Furthermore, numbers shouldn't need a monospace font at all. |
Problem with this approach is that we're masking with '#' which isn't the same width as digits, and there doesn't seem to be a good substitute. Best I could come up with was https://dpaste.com/2H7QFU9BZ |
|
Wouldn't this just have to be chanaged all over again when we decide to embed the fonts? (#79) |
There was a problem hiding this comment.
Concept 0 on this
Embedding the font as proposed in #79 is the way to go. In embedding the font we can effectively eliminate the current issues surrounding the representation of monospace characters. This change will not directly address the issue where the font is not available, we assume that linux will choose an appropriate monospace font.
My opinion is that we should focus on #79 instead of devoting review time to this
Hopefully your comment is addressed in #79 (comment) |
|
Closing in favor of #79. |
The bitcoin/bitcoin@8d75115 (bitcoin/bitcoin#16432) introduced a monospaced font for tabulated figures.
But the Qt's font matching algorithm does not guarantee that:
.AppleSystemUIFontwhich is not monospaced, i.e.,QFontInfo::fixedPitch()returnsfalse)*.uifile #87 (comment) "I think the correct monospace font should be bigger and eventually bold")This change suggests to use Courier New explicitly which is available on Windows and macOS by default.
On Linux systems the Qt substitutes the missed Courier New font (in case it is not installed) quite well. For example, the Liberation Mono is used on my system.
This is an alternative to #87. But personally I still lean to embedding font (#79).