WIP qt: mempool stats chart #320

RandyMcMillan · 2021-05-06T08:14:43Z

add graphical mempool display to Node window

RandyMcMillan · 2021-05-06T08:16:24Z

There is a lot if interest in #108
This is a rebase of original PR - it has grown stale.

Sjors · 2021-05-06T09:20:15Z

Thanks for picking this up. Looks like it broke a few CI instances, probably because of the compiler warnings (that are treated as errors).

jarolrod

Concept ACK

I don't know if @jonasschnelli has completely given up on his original PR yet.

This is still very much a work in progress. So, it should be labeled as such and made into a draft.

When you push changes, it would be nice if you could write a small post explaining what has changed between updates. This makes it easier for people to follow along.

jarolrod · 2021-05-08T17:57:29Z

src/qt/mempoolstats.cpp

+static const int GRAPH_PADDING_TOP_LABEL = 10;
+static const int GRAPH_PADDING_BOTTOM = 50;
+
+void ClickableTextItem::mousePressEvent(QGraphicsSceneMouseEvent *event)


Clicking on the text item next to the RECT still reliably causes a segmentation fault

0 org.qt-project.QtCore 0x0000000103eb5bf9 0x103c9f000 + 2190329 1 bitcoin-qt 0x00000001029ad160 ClickableRectItem::objectClicked(QGraphicsItem*) + 64 (moc_mempoolstats.cpp:247) 2 org.qt-project.QtCore 0x0000000103eb6042 0x103c9f000 + 2191426 3 bitcoin-qt 0x00000001029acea0 ClickableTextItem::objectClicked(QGraphicsItem*) + 64 (moc_mempoolstats.cpp:134)

rebroad · 2021-05-12T08:57:46Z

Has anyone worked out how to make the Y axis show memory usage rather than tx count? (ideally in a way that it shows a flat line once we reach the maxmempool).

Sjors · 2021-05-13T19:00:56Z

I would prefer MB over count too if it's not too difficult. I might take a look a later to see how...

Can you split this PR a bit? E.g. one commit for the src/interfaces changes, one for mempoolstats.cpp (which probably should mostly be moved out of the GUI code), one for the UI change, etc.

Also for a followup: little dots to indicate your wallet unconfirmed transactions :-)

ghost · 2021-05-15T02:30:31Z

Concept ACK

Has anyone worked out how to make the Y axis show memory usage rather than tx count? (ideally in a way that it shows a flat line once we reach the maxmempool).

There should be a way to select Tx count or vSize

Not sure if others will agree with it or maybe we can do this in follow up PRs, I created a rough design of mempool tab:

Left: History for mempool over a time period. User can select the time frame.

Right: Current fee rate distribution in mempool. I have used image from https://btc.bitaps.com (An option to switch between Tx count and vSize can be added)

User can enter a transaction id in the text edit widget to see where it is in the mempool (similar to https://mempool.observer):

Can be highlighted in the 'fee distribution' graph with dotted lines. I have used dotted lines and "glasses" sticker:

@RandyMcMillan

Co-authored-by: Jonas Schnelli <[email protected]> Co-authored-by: @RandyMcMillan <[email protected]>

0xB10C · 2021-05-21T09:42:37Z

I agree that insights into a nodes mempool are really interesting and useful. I too understand that users want to use their own full node and not rely on external services. However, I'm not sure if the Bitcoin Core GUI is the right place for it.

From my experience, different types of users want different stats, charts, chart axis and so forth... I think having good interfaces to access this data and then visualizing it, for example, on a web page, scales way better and requires much less maintenance on the Bitcoin Core side. I'm leaning towards a Concept NACK for now.

Disclaimer: I run such a site visualizing the mempool of my node, but I don't think this influences my reasoning here. I have no incentive to NACK here. I don't make money off site visitors. The hosting is payed by myself and donations (sometimes listed as sponsors) and I'm not compensated for my time maintaining it.

hebasto · 2021-05-21T14:51:19Z

@0xB10C

I agree that insights into a nodes mempool are really interesting and useful. I too understand that users want to use their own full node and not rely on external services. However, I'm not sure if the Bitcoin Core GUI is the right place for it.

From my experience, different types of users want different stats, charts, chart axis and so forth... I think having good interfaces to access this data and then visualizing it, for example, on a web page, scales way better and requires much less maintenance on the Bitcoin Core side. I'm leaning towards a Concept NACK for now.

Disclaimer: I run such a site visualizing the mempool of my node, but I don't think this influences my reasoning here. I have no incentive to NACK here. I don't make money off site visitors. The hosting is payed by myself and donations (sometimes listed as sponsors) and I'm not compensated for my time maintaining it.

Could we limit this feature to some set of data (texts, tables, charts) that just could give to a pro-user useful info to manually set a feerate for his transaction?

Rspigler · 2021-05-21T19:37:38Z

I am a strong Concept ACK for @prayank23 's design. Improving Core's GUI and widening the user base is important.

Sjors · 2021-05-22T11:45:41Z

Personally I'm happy to review and test this, and it's something I would use. Mempool weather is something I check before and during every transaction. Although websites can indeed iterate faster, it's nice to have it in the node. The Hoenicke design that this is based on hasn't changed in many years, so I'm also not terribly worried about maintenance.

And if we correctly split the data collection (node & rpc: seperate PR) from the visualisation (gui), then there may be other use cases too.

Rspigler · 2021-06-09T04:31:39Z

😞 Reason for close? Mark up for grabs?

ghost · 2021-06-17T03:36:20Z

@0xB10C

However, I'm not sure if the Bitcoin Core GUI is the right place for it.

Mempool related charts and options are a basic thing which should have been there in Bitcoin Core GUI few years back. Sad that we won't see it in v22.0 but still not too late to start working on it for future release.

From my experience, different types of users want different stats, charts, chart axis and so forth.

Agree. But that is true for lot of things in Bitcoin Core GUI. We should add atleast basic things that everyone finds useful.

I think having good interfaces to access this data and then visualizing it, for example, on a web page, scales way better and requires much less maintenance on the Bitcoin Core side.

Yes, website works better for charts. However, both can be used. One or two basic charts and options in Core GUI and other detailed mempool stats on different websites.

Is https://mempool.observer open source? Can users run it locally and use their own node? That would be helpful

Rspigler · 2021-06-21T03:53:02Z

users want to use their own full node and not rely on external services

This.

rebroad · 2021-06-26T16:55:58Z

I would prefer MB over count too if it's not too difficult. I might take a look a later to see how...

Can you split this PR a bit? E.g. one commit for the src/interfaces changes, one for mempoolstats.cpp (which probably should mostly be moved out of the GUI code), one for the UI change, etc.

Also for a followup: little dots to indicate your wallet unconfirmed transactions :-)

I've managed to do this... but I cheated a little bit as there is memory used in addition to the TXs that fluctuates over time, so if you want a nice flat line when your node starts pruning TXs from the mempool, then you won't get that unless you cheat :) (which I have). I will upload my patches soon.

kristapsk · 2021-07-12T20:47:31Z

Concept ACK

However, I'm not sure if the Bitcoin Core GUI is the right place for it.

Mempool related charts and options are a basic thing which should have been there in Bitcoin Core GUI few years back. Sad that we won't see it in v22.0 but still not too late to start working on it for future release.

I agree with @prayank23 here, if you use Bitcoin Core as a wallet (and I don't see a reason running GUI if you don't), this is probably the most important metric to decide what transaction fee to use for transaction.

promag · 2021-07-13T10:34:34Z

Concept ACK.

@0xB10C I think some basic mempool viz is reasonable. Will review.

0xB10C · 2021-07-13T10:56:32Z

Thanks everybody for the feedback and discussion. I've reconsidered my position on this. I agree that some basic mempool weather in the GUI makes sense.

Rspigler · 2021-07-13T16:22:11Z

People who have (Concept) ACKd this should look at #108

ghost · 2021-08-30T01:08:56Z

@RandyMcMillan Do you want to reopen this? I can work on it if you have bandwidth issues

ghost · 2021-09-03T21:29:29Z

Why do I see a different chart and nothing on right with Detail Stub written?

Screenshot

If I stretch that part to right, this is how it looks:

Screenshot

Same thing on Ubuntu and Windows.

Chart in [Qt] Add interactive mempool graph bitcoin/bitcoin#8550 looks better IMO:

Screenshot

Or maybe we can just draw a simple bar chart with Add feerate histogram to getmempoolinfo bitcoin/bitcoin#21422 and https://doc.qt.io/qt-5/qtcharts-barchart-example.html

I had used the results of getmempoolinfo to create a similar chart using Python Flask: bitcoin/bitcoin#21422 (comment)

Screenshot

So which chart would look better and everyone agrees to add in Node window?

RandyMcMillan · 2021-11-10T05:04:42Z

rebase

https://github.com/bitcoincore-dev/gui/tree/mempool_graph_rebase

RandyMcMillan mentioned this pull request May 6, 2021

WIP: mempool stats chart #108

Closed

4 tasks

RandyMcMillan force-pushed the mempool_graph_rebase branch 11 times, most recently from e5b3ab8 to 1baeb53 Compare May 7, 2021 19:51

jarolrod reviewed May 8, 2021

View reviewed changes

RandyMcMillan changed the title ~~qt: mempool stats chart~~ WIP qt: mempool stats chart May 8, 2021

RandyMcMillan marked this pull request as draft May 8, 2021 19:11

hebasto added the Feature label May 9, 2021

RandyMcMillan force-pushed the mempool_graph_rebase branch from 1baeb53 to daeadd2 Compare May 14, 2021 19:53

qt: mempool stats chart

b6d0a95

Co-authored-by: Jonas Schnelli <[email protected]> Co-authored-by: @RandyMcMillan <[email protected]>

RandyMcMillan force-pushed the mempool_graph_rebase branch from daeadd2 to b6d0a95 Compare May 16, 2021 01:27

RandyMcMillan closed this Jun 7, 2021

ghost mentioned this pull request Jul 12, 2021

Implement BIP-119 Validation (CheckTemplateVerify) bitcoin/bitcoin#21702

Closed

ghost mentioned this pull request Sep 5, 2021

Add fee rate distribution in -getinfo bitcoin/bitcoin#22891

Closed

bitcoin-core locked and limited conversation to collaborators Nov 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP qt: mempool stats chart #320

WIP qt: mempool stats chart #320

RandyMcMillan commented May 6, 2021 •

edited

Loading

RandyMcMillan commented May 6, 2021 •

edited

Loading

Sjors commented May 6, 2021

jarolrod left a comment

jarolrod May 8, 2021

rebroad commented May 12, 2021

Sjors commented May 13, 2021 •

edited

Loading

ghost commented May 15, 2021 •

edited by ghost

Loading

0xB10C commented May 21, 2021

hebasto commented May 21, 2021

Rspigler commented May 21, 2021

Sjors commented May 22, 2021 •

edited

Loading

Rspigler commented Jun 9, 2021

ghost commented Jun 17, 2021

Rspigler commented Jun 21, 2021

rebroad commented Jun 26, 2021

kristapsk commented Jul 12, 2021

promag commented Jul 13, 2021

0xB10C commented Jul 13, 2021

Rspigler commented Jul 13, 2021

ghost commented Aug 30, 2021

ghost commented Sep 3, 2021 •

edited by ghost

Loading

RandyMcMillan commented Nov 10, 2021 •

edited

Loading

WIP qt: mempool stats chart #320

WIP qt: mempool stats chart #320

Conversation

RandyMcMillan commented May 6, 2021 • edited Loading

RandyMcMillan commented May 6, 2021 • edited Loading

Sjors commented May 6, 2021

jarolrod left a comment

Choose a reason for hiding this comment

jarolrod May 8, 2021

Choose a reason for hiding this comment

rebroad commented May 12, 2021

Sjors commented May 13, 2021 • edited Loading

ghost commented May 15, 2021 • edited by ghost Loading

0xB10C commented May 21, 2021

hebasto commented May 21, 2021

Rspigler commented May 21, 2021

Sjors commented May 22, 2021 • edited Loading

Rspigler commented Jun 9, 2021

ghost commented Jun 17, 2021

Rspigler commented Jun 21, 2021

rebroad commented Jun 26, 2021

kristapsk commented Jul 12, 2021

promag commented Jul 13, 2021

0xB10C commented Jul 13, 2021

Rspigler commented Jul 13, 2021

ghost commented Aug 30, 2021

ghost commented Sep 3, 2021 • edited by ghost Loading

RandyMcMillan commented Nov 10, 2021 • edited Loading

RandyMcMillan commented May 6, 2021 •

edited

Loading

RandyMcMillan commented May 6, 2021 •

edited

Loading

Sjors commented May 13, 2021 •

edited

Loading

ghost commented May 15, 2021 •

edited by ghost

Loading

Sjors commented May 22, 2021 •

edited

Loading

ghost commented Sep 3, 2021 •

edited by ghost

Loading

RandyMcMillan commented Nov 10, 2021 •

edited

Loading