Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcpkg installation instructions #1137

Closed

Conversation

JonLiu1993
Copy link

secp256k1 is available as a port in vcpkg, a C++ library manager that simplifies installation for secp256k1 and other project dependencies. Documenting the install process here will help users get started by providing a single set of commands to build secp256k1, ready to be included in their projects.

We also test whether our library ports build in various configurations (dynamic, static) on various platforms (OSX, Linux, Windows: x86, x64) to keep a wide coverage for users.

I'm a maintainer for vcpkg, and here is what the port script looks like. We try to keep the library maintained as close as possible to the original library. :)

Comment on lines +119 to +122
Building secp256k1 - Using vcpkg
------------

You can download and install secp256k1 using the [vcpkg](https://github.com/Microsoft/vcpkg) dependency manager:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Building" is not "download and install" :)

This file contains no references to any package manager which provides the secp256k1 package. Seeing no reasons to make an exception for the vcpkg.

@real-or-random
Copy link
Contributor

It's really awesome to see that the library is packaged in various places (also some Linux distros) even though we have been lazy with releases. Thanks for these efforts, and we really hope this will be easier once we have a release out. (#1055) And feel free to ping us here whenever there's an issue.

On the other hand, the one build method that we currently officially support is the one currently described in the README, and yes, I don't think it would make sense for us to have instructions for other build systems in our repo.

But let me stress that it's great that there is a vcpkg!

@sipa
Copy link
Contributor

sipa commented Aug 25, 2022

Echoing what @real-or-random said, but also: if we add cmake as build system (#1113), which presumably will be MSVC compatible, I would expect these instructions to shrink significantly?

@real-or-random
Copy link
Contributor

@sipa vcpkg is somewhat agnostic of the compiler. It uses MSVC on Windows but gcc/g++ on Linux.

@hebasto
Copy link
Member

hebasto commented Nov 30, 2022

if we add cmake as build system (#1113), which presumably will be MSVC compatible

It is MSVC compatible :)

@real-or-random
Copy link
Contributor

Closing this but please feel free to discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants