Make ec_ arithmetic more consistent and add documentation#701

Merged

real-or-random merged 10 commits intobitcoin-core:masterfrom jonasnick:arithmetic-consistency

Apr 30, 2020

+290-92

Commits on Mar 30, 2020

Add scalar_set_b32_seckey which does the same as scalar_set_b32 and also returns whether it's a valid secret key
jonasnick
committed
Use scalar_set_b32_seckey in ecdsa_sign, pubkey_create and seckey_verify
jonasnick
committed
Add test for boundary conditions of scalar_set_b32 with respect to overflows
jonasnick
committed
Return 0 if the given seckey is invalid in privkey_negate, privkey_tweak_add and privkey_tweak_mul
jonasnick
committed
Define valid ECDSA keys in the documentation of seckey_verify
jonasnick
committed
Mention that value is unspecified for In/Out parameters if the function returns 0
jonasnick
committed
Rename private key to secret key in public API (with the exception of function names)
jonasnick
committed
Make ec_privkey functions aliases for ec_seckey_negate, ec_seckey_tweak_add and ec_seckey_mul
jonasnick
committed
Make tweak function documentation more consistent.
jonasnick
committed
Clarify documentation of tweak functions.
jonasnick
committed