Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Update ACK description in CONTRIBUTING.md #15626

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Docs: Update ACK description in CONTRIBUTING.md #15626

merged 1 commit into from
Mar 20, 2019
+4 −1

Conversation

jonatack
Copy link
Member

@jonatack jonatack commented Mar 20, 2019 •
edited
Loading

@fanquake fanquake added the Docs label Mar 20, 2019
laanwj
laanwj reviewed Mar 20, 2019
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@jonatack jonatack force-pushed the update-ack-description-in-contributing-md branch from 731414d to 0d9d2b3 Compare March 20, 2019 11:11
@promag
Copy link
Contributor

promag commented Mar 20, 2019

ACK 0d9d2b3.

@laanwj
Copy link
Member

laanwj commented Mar 20, 2019

Looks good to me now, thanks

ACK 0d9d2b3

@laanwj laanwj merged commit 0d9d2b3 into bitcoin:master Mar 20, 2019
laanwj added a commit that referenced this pull request Mar 20, 2019
@laanwj
Merge #15626: Docs: Update ACK description in CONTRIBUTING.md
bbc436e 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per #15617 (comment).

  Edit:

  as per #15617 (comment) and #15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
marcinja pushed a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019
@jonatack @marcinja
Doc: update ACK description in CONTRIBUTING.md
8cfdf0c 
as per bitcoin#15617 (comment) and bitcoin#15626 (comment).
marcinja pushed a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019
@jonatack @marcinja
Doc: update ACK description in CONTRIBUTING.md
2f60596 
as per bitcoin#15617 (comment) and bitcoin#15626 (comment).
@jonatack jonatack deleted the update-ack-description-in-contributing-md branch March 21, 2019 10:31
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Aug 30, 2019
@jonatack
Doc: update ACK description in CONTRIBUTING.md
6554cea 
as per bitcoin#15617 (comment) and bitcoin#15626 (comment).
barrystyle pushed a commit to zentoshi/zentoshi that referenced this pull request Nov 11, 2019
@jonatack @barrystyle
Doc: update ACK description in CONTRIBUTING.md
57d5dd3 
as per bitcoin/bitcoin#15617 (comment) and bitcoin/bitcoin#15626 (comment).
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 27, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
5851979 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 28, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
02f8e75 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 29, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
6dacf59 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
e386e99 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
fb8d075 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 8, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
47ddb26 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 10, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#15626: Docs: Update ACK description in CONTRIBUTING.md
368f5f0 
0d9d2b3 Doc: update ACK description in CONTRIBUTING.md (Jon Atack)

Pull request description:

  as per bitcoin#15617 (comment).

  Edit:

  as per bitcoin#15617 (comment) and bitcoin#15626 (comment).

Tree-SHA512: 12df420d20338270bca310873c73d2f38b631c05cf8b3e5b2c1380f95936cb122687ba66b71de53348222efd5fed6d21e67f535a6ada689bf294dceec184a631
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonatack @promag @laanwj @fanquake