Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm getAddress #1085

Merged
merged 2 commits into from
May 30, 2018
Merged

rm getAddress #1085

merged 2 commits into from
May 30, 2018

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented May 22, 2018 •
edited
Loading

No description provided.

@dcousens dcousens added this to the 4.0.0 milestone May 22, 2018
@dcousens dcousens self-assigned this May 22, 2018
@dcousens
Copy link
Contributor Author

Part of #1017

@dcousens dcousens changed the title rm getAddress (wip), add payments rm getAddress May 29, 2018
@dcousens dcousens requested a review from junderw May 29, 2018 13:09
@dcousens
Copy link
Contributor Author

dcousens commented May 29, 2018 •
edited
Loading

@junderw good to merge (on travis passing), removal of getAddress only for now, payments PR will be separate

@dcousens dcousens mentioned this pull request May 30, 2018
Merged
@dcousens dcousens mentioned this pull request May 30, 2018
Merged
@junderw
Copy link
Member

junderw commented May 30, 2018

Could you change requires to use const instead of let?

regex replace let(\s+\S+\s+=\s+require\('[^']+'\)) with const$1

@dcousens
Copy link
Contributor Author

@junderw I intend to do that in a mass PR after this stage. For now, I'm changing to let on anything I touch.

junderw
junderw approved these changes May 30, 2018
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey dokey

@junderw junderw merged commit 4942267 into master May 30, 2018
@dcousens dcousens deleted the payments branch May 30, 2018 05:51
@dcousens dcousens modified the milestone: 4.0.0 Jul 17, 2018
@takahser takahser mentioned this pull request Nov 13, 2018
Closed
@takahser
Copy link

how can we get testnet addresses after this merge? when using payments.p2pkh, a p2pkh address is returned, rather than a testnet address (starting with m or n)

@junderw
Copy link
Member

junderw commented Nov 13, 2018

@takahser pass the testnet network.

@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees

@dcousens dcousens

Labels
breaking change feature refactor
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dcousens @junderw @takahser