Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some small bugs #1307

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Fix some small bugs #1307

merged 1 commit into from
Dec 29, 2018

Conversation

junderw
Copy link
Member

@junderw junderw commented Dec 29, 2018

  • txb internal function prepareInput doesn't use witnessValue at all. Got rid of it.
  • p2ms a.input validation check doesn't check the stacksEqual properly. Added a test to check it.

TypeError: a.signatures.equals is not a function when I add the new test to before the fix.

@junderw junderw requested a review from dcousens December 29, 2018 08:09
@junderw junderw added the bug label Dec 29, 2018
dcousens
dcousens approved these changes Dec 29, 2018
View reviewed changes
Copy link
Contributor

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junderw junderw merged commit 46c1991 into master Dec 29, 2018
@dcousens dcousens deleted the bugFixes branch December 29, 2018 13:47
@dcousens dcousens mentioned this pull request Jan 24, 2019
Closed
@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junderw @dcousens