Adding function to decide if HDNode is private #536
Conversation
|
Nice! Maybe That way a scenario could play out as: if (!node.isNeutered()) node = node.neutered() |
|
Also, are you up to add some tests? 👍 |
|
Hm. On one hand, it makes sense, because it's consistent, on the other hand I just wouldn't guess from the name what it means. I will look more into the travis failures (seems like style issue... that's what I get for editing code in github GUI :)) |
| @@ -281,6 +281,10 @@ HDNode.prototype.deriveHardened = function (index) { | |||
| return this.derive(index + HDNode.HIGHEST_BIT) | |||
| } | |||
|
|
|||
| HDNode.prototype.isPrivate = function () { | |||
| return !!(this.keyPair.d); | |||
|
I wouldn't be opposed to having both then I guess? Its just more to maintain and think about. @fanatid thoughts? |
|
In any case @Runn1ng, please add tests in lieu of the naming bike shed. |
|
Since |
|
I have renamed the function and removed the semicolon. Now I am adding tests |
Public === neutered. Private === not neutered
To test removing private information, it's probably better to start with them :)
|
I have added some tests. Is it OK like this? |
|
...stupid semicolons! :D ok now? |
|
....the test failure is timeout failure and not related to my changes (I think). |
| @@ -240,7 +242,7 @@ describe('HDNode', function () { | |||
| var f = fixtures.valid[0] | |||
|
|
|||
| it('strips all private information', function () { | |||
| var hd = HDNode.fromBase58(f.master.base58, NETWORKS_LIST) | |||
| var hd = HDNode.fromBase58(f.master.base58Priv, NETWORKS_LIST) | |||
|
Sorry for the screw around @Runn1ng... 👍 |
|
Bugger it actually, thanks @Runn1ng 👍 If |
Adding function to decide if HDNode is private
|
Won't publish for a little while yet, will be in |
It's a very simple function that probably isn't that important, but can help someone.
If you like this idea, I will add some tests for that