script: always compile in a minimaldata compliant way #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Sep 29, 2016
| fixtures.valid.forEach(function (f) { | ||
| if (f.scriptSig) { | ||
| it('(' + f.type + ') compiles ' + f.scriptSig, function () { | ||
| var scriptSig = bscript.fromASM(f.scriptSig) | ||
|
|
||
| assert.strictEqual(bscript.compile(scriptSig).toString('hex'), f.scriptSigHex) |
There was a problem hiding this comment.
the explicit compile here was actually a double up (it is already done in fromASM), I updated the description of the test and removed it
dcousens
commented
Sep 29, 2016
|
|
||
| assert.strictEqual(bscript.compile(chunksNS).toString('hex'), f.scriptSigHex) | ||
|
|
||
| // toASM converts verbatim, only `compile` transforms the script to a minimalpush compliant script |
There was a problem hiding this comment.
and here lies some more confusing aspects of this change
|
Fixes #631 |
|
ping @fanatid, @jprichardson, @rubensayshi, @Runn1ng, @Sjors for any opinions |
|
We probably need more non-standard script tests anyway... |
|
any comments? |
|
This is in line with #640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't decide if this is the right thing to do.
On the one hand, I can't imagine another work flow that isn't a pain in the ass, but at the same time it means
decompile(compile(x)) !== xin more cases.Existing exceptions already exist around non-standard data pushes... so I suppose that makes it more acceptable?