Rename __hasWitnesses -> hasWitnesses, and add tests #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
reviewed
Dec 7, 2016
| } | ||
|
|
||
| it('detects if the transaction has witnesses: ' + (witnesses ? 'true' : 'false'), function () { | ||
| assert.strictEqual(Transaction.fromHex(hex).hasWitnesses(), witnesses) |
There was a problem hiding this comment.
couldn't it just be
assert.strictEqual(Transaction.fromHex(hex).hasWitnesses(), !!f.whex)
?
There was a problem hiding this comment.
Yep could be shortened, done :)
|
ACK, waiting on travis |
afk11
force-pushed
the
test-has-witness
branch
from
b3d19e1 to
7ec001c
Compare
|
Just one integration test failed, will restart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #703