Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce decodeStack receives a stack array #942

Merged
merged 2 commits into from
Dec 1, 2017
Merged

enforce decodeStack receives a stack array #942

merged 2 commits into from
Dec 1, 2017

Conversation

dcousens
Copy link
Contributor

@dcousens dcousens commented Nov 30, 2017 •
edited
Loading

Burned by this twice, a Buffer can pass check because of ambiguity in decompile, returning a .slice of bytes, not chunks, which makes zero sense.

@dcousens dcousens requested review from fanatid and junderw November 30, 2017 04:35
@dcousens dcousens added the bug label Nov 30, 2017
afk11
afk11 approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@afk11 afk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK

@dcousens
Copy link
Contributor Author

dcousens commented Dec 1, 2017

Added 34df503 to fix the unit tests

@dcousens dcousens merged commit 42407e2 into master Dec 1, 2017
@dcousens dcousens deleted the stackme branch December 1, 2017 02:08
@Ashtonulliac Ashtonulliac mentioned this pull request Aug 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afk11 afk11 afk11 approved these changes

@fanatid fanatid Awaiting requested review from fanatid

@junderw junderw Awaiting requested review from junderw

Assignees
No one assigned
Labels
bug refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcousens @afk11